Carry include_confidence through the SDK and CLI - #30
Merged
Merged
Conversation
Regenerated from the branch's own OpenAPI spec via gen_requests.py --spec rather than edited by hand, since that file says not to. The regen also picks up an integration_id description that had drifted since native-icp shipped. Ordering: contract.yml checks a PR targeting development against DEV_SPEC_URL, so this needs the platform change on api-dev before the SDK PR opens, not a prod deploy. Until then check_contract.py and gen_requests.py --check both disagree, because the spec they read does not carry the field yet.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
DiscoGen's typed-column detector (which columns run through TypeSafe judgment instead of generated prose) is picked server-side from the query text; the client only opts in with a bool, same shape as include_confidence which already made the trip last commit. Hand-added to _generated/requests.py rather than regenerated, since api-dev does not serve this field yet (same ordering constraint as include_confidence).
The flag has distinct true, false, and unset wire behavior but no dedicated test exercised any of it for run or run-personas.
A PR stacked on a feature branch is as far ahead of prod as the branch it targets, but base_ref only matched "development" literally, so the stack fell through to the prod spec and reported every unreleased field as a missing one. Fork PRs still get the prod spec, since they never receive DEV_SPEC_URL.
…typed-columns # Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md # packages/discolike-cli/tests/test_discogen_cli.py
Carry the typed_columns opt-in flag through the SDK and CLI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
include_confidencetodiscogen.processanddiscogen.process_personas, plus--include-confidenceon the CLI. It applies to typed DiscoGen columns, which the platform answers with a TypeSafe judgment model rather than generated prose._generated/requests.pywas regenerated withgen_requests.py --specagainst the platform branch's own OpenAPI, not hand-edited. The regen also picks up anintegration_iddescription that had drifted sincenative-icpshipped.Blocked until the platform change is on api-dev.
contract.ymlchecks a PR targetingdevelopmentagainstDEV_SPEC_URL, socheck_contract.pyandgen_requests.py --checkwill both disagree until then. Platform side is discolike/discolike-platform!885.The PR appears safe to merge once its stated external platform dependency is available; no actionable code defect remains in the reviewed changes.
Summary
The PR carries typed-column confidence controls through the generated SDK request models and both DiscoGen CLI commands, adds request-serialization coverage for all
include_confidencestates, and updates contract checking for stacked non-main branches.typed_columnsandinclude_confidencerequest fields for domain and persona DiscoGen processing.include_confidence.Reviews (2) · Last reviewed commit: "Trigger checks for the merged typed-colu..."