Repository navigation
add idempotency key to leader selected mode collection job requests - #4893
Closed
tgeoghegan wants to merge 4 commits into
Closed
tgeoghegan wants to merge 4 commits into
tgeoghegan wants to merge 4 commits into
Conversation
Contributor
Author
|
Draft so I can see what breaks in CI. |
Contributor
Author
|
I was pleasantly surprised to see that this doesn't actually require any DB schema changes: we already store the encoded collection job query in That said, we should add an index for looking up collection jobs by (task_id, query). |
tgeoghegan
added
allow-changed-migrations
Moving toward server-selected resource identifiers means that HTTP clients need to parse resource identifiers from URIs provided by servers in `Location` HTTP headers. This adds an extension trait `HeaderMapExt` with method `ids_from_collection_job_location`. It finds a `Location` header and parses its value, extracting the task and collection job IDs. In the future, we'll need to do this for aggregate shares and aggregation jobs, too, at which point we can make this method generic over types that can be parsed from Base64URL. But for now, we specialize to collection jobs.
tgeoghegan
force-pushed
the
timg/leader-selected-collection-job-idempotency-key
branch
from
October 9, 2026 20:34
4281657 to
b2a2523
Compare
This was referenced Oct 13, 2026
Contributor
Author
|
Closing, these changes are being handled elsewhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the proposed DAP change in ietf-wg-ppm/draft-ietf-ppm-dap#797. One unexpected quirk here: because the collection job req is bound into the AAD on the aggregate shares, the idempotency key has to be transmitted to the helper. That's not a problem, as such, it's just odd, since there's absolutely no decision that the helper could ever make with that value. But then as I observed in the DAP PR, the problem we're solving is irreducibly ugly, and that will be reflected in its solution.