Repository navigation
Validate LocalTime result state and track SQL NULL - #923
Merged
staticlibs merged 1 commit intoOct 10, 2026
Merged
staticlibs merged 1 commit into
staticlibs merged 1 commit into
Conversation
Signed-off-by: hutiefang76 <137664623+hutiefang76@users.noreply.github.com>
staticlibs
approved these changes
Oct 10, 2026
staticlibs
left a comment
staticlibs
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR! Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DuckDBResultSet.getLocalTimebypasses the result-set state and null checks: invalid cursor access can throw runtime exceptions, and reading SQL NULL leaveswasNull()stale. Use the samecheckAndNullguard as the other supported getters.Four regression tests cover nanosecond TIME values, SQL NULL, index and label access, invalid indices, before/after-row access, and closed results. The null and state regressions fail with the original production source. All 33
TestTimestamptests and 12TestResultstests pass with freshly compiled Java sources and the cached native driver. clang-format 11 passes; a native rebuild was not performed locally.AI assistance was used for implementation and test development.