Skip to content

Validate LocalTime result state and track SQL NULL #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staticlibs merged 1 commit into from
Oct 10, 2026
Merged

Validate LocalTime result state and track SQL NULL #923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/java/org/duckdb/DuckDBResultSet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,9 @@ public Time getTime(int columnIndex) throws SQLException {
}

public LocalTime getLocalTime(int columnIndex) throws SQLException {
if (checkAndNull(columnIndex)) {
return null;
}
return currentChunk[columnIndex - 1].getLocalTime(chunkIdx - 1);
}

Expand Down
60 changes: 60 additions & 0 deletions src/test/java/org/duckdb/TestTimestamp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,6 +641,66 @@ public static void test_time_ns() throws Exception {
}
}

public static void test_local_time_getter_ns() throws Exception {
try (Connection conn = DriverManager.getConnection(JDBC_URL); Statement stmt = conn.createStatement()) {
stmt.execute("CREATE TABLE t (i TIME_NS)");
stmt.execute("INSERT INTO t VALUES ('01:02:03.456789012')");
try (DuckDBResultSet rs = (DuckDBResultSet) stmt.executeQuery("SELECT i FROM t")) {
assertTrue(rs.next());
assertEquals(rs.getLocalTime(1), LocalTime.of(1, 2, 3, 456789012));
assertFalse(rs.wasNull());
assertEquals(rs.getLocalTime("i"), LocalTime.of(1, 2, 3, 456789012));
assertFalse(rs.wasNull());
assertFalse(rs.next());
}
}
}

public static void test_local_time_getter_null() throws Exception {
try (Connection conn = DriverManager.getConnection(JDBC_URL); Statement stmt = conn.createStatement()) {
stmt.execute("CREATE TABLE t (i TIME_NS)");
stmt.execute("INSERT INTO t VALUES ('01:02:03.456789012'), (NULL)");
try (DuckDBResultSet rs = (DuckDBResultSet) stmt.executeQuery("SELECT i FROM t ORDER BY rowid")) {
assertTrue(rs.next());
assertEquals(rs.getLocalTime(1), LocalTime.of(1, 2, 3, 456789012));
assertFalse(rs.wasNull());

assertTrue(rs.next());
assertNull(rs.getLocalTime(1));
assertTrue(rs.wasNull());
assertNull(rs.getLocalTime("i"));
assertTrue(rs.wasNull());

assertFalse(rs.next());
}
}
}

public static void test_local_time_getter_invalid_index() throws Exception {
try (Connection conn = DriverManager.getConnection(JDBC_URL); Statement stmt = conn.createStatement();
DuckDBResultSet rs = (DuckDBResultSet) stmt.executeQuery("SELECT TIME '01:02:03' AS t")) {
assertThrows(() -> rs.getLocalTime(1), SQLException.class);
assertThrows(() -> rs.getLocalTime("t"), SQLException.class);
assertTrue(rs.next());
assertThrows(() -> rs.getLocalTime(0), SQLException.class);
assertThrows(() -> rs.getLocalTime(2), SQLException.class);
assertThrows(() -> rs.getLocalTime("nope"), SQLException.class);
assertFalse(rs.next());
assertThrows(() -> rs.getLocalTime(1), SQLException.class);
assertThrows(() -> rs.getLocalTime("t"), SQLException.class);
}
}

public static void test_local_time_getter_closed() throws Exception {
try (Connection conn = DriverManager.getConnection(JDBC_URL); Statement stmt = conn.createStatement()) {
DuckDBResultSet rs = (DuckDBResultSet) stmt.executeQuery("SELECT TIME '01:02:03' AS t");
assertTrue(rs.next());
rs.close();
assertThrows(() -> rs.getLocalTime(1), SQLException.class);
assertThrows(() -> rs.getLocalTime("t"), SQLException.class);
}
}

public static void test_bug532_timestamp() throws Exception {
try (Connection conn = DriverManager.getConnection(JDBC_URL); Statement stmt = conn.createStatement()) {

Expand Down
Loading