fix(core): request timeout and visible per-target errors - #21
Merged
Merged
Conversation
…all polling The poller marks itself running for the whole cycle; a fetch that never settles (seen after a network change) left it stuck on 'Checking…' for hours. Every request now aborts after 20 s and the cycle moves on.
… ok status A 404 on a private repo (token without the repo scope) was reported for a split second and then overwritten by 'last check ok'. Failed targets now keep the status red with a hint about the missing scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
reposcope) now keeps the status red with a hint, instead of being overwritten by "last check ok" in the same cycle.Verified
Found live: poller frozen since 01:15 with state unchanged; repo target returning 404 with the app token while
ghreturned 200. tsc, 17 tests.