Skip to content

fix(ui): avatar URLs with the size parameter first #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eJosR-Coding merged 1 commit into from
Sep 17, 2026
Merged

fix(ui): avatar URLs with the size parameter first #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions src/ui/ui.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,25 @@ import {

export type View = "activity" | "settings";

/**
* GitHub's avatar CDN caches per exact query string, and `?v=4&s=96`
* (size appended after the API's `v`) can serve a stale identicon while
* `?s=96&v=4` (the order github.com itself uses) serves the real photo.
* Build the URL the way the website does.
*/
export function avatarAt(url: string, size: number): string {
try {
const u = new URL(url);
const v = u.searchParams.get("v");
u.search = "";
u.searchParams.set("s", String(size));
if (v) u.searchParams.set("v", v);
return u.toString();
} catch {
return url;
}
}

/** Push the tint opacity into CSS. 1 = opaque. */
export function applyGlass(opacity: number): void {
document.documentElement.style.setProperty("--glass", String(Math.min(1, Math.max(0.3, opacity))));
Expand Down Expand Up @@ -121,7 +140,7 @@ export class Ui {
for (const [img, nameEl, loginEl] of [["#id-avatar", "#id-name", "#id-login"], ["#acc-avatar", "#acc-name", "#acc-login"]]) {
const i = $<HTMLImageElement>(img);
i.hidden = !avatarUrl;
if (avatarUrl) i.src = `${avatarUrl}&s=96`;
if (avatarUrl) i.src = avatarAt(avatarUrl, 96);
$(nameEl).textContent = name || login!;
$(loginEl).textContent = `@${login}`;
}
Expand Down Expand Up @@ -493,7 +512,7 @@ export class Ui {
<time>${when}</time>
</div>`;
const img = li.querySelector<HTMLImageElement>("img")!;
if (n.avatar) img.src = `${n.avatar}&s=64`;
if (n.avatar) img.src = avatarAt(n.avatar, 64);
else img.replaceWith(Object.assign(document.createElement("span"), { className: "notice-dot" }));
const a = li.querySelector<HTMLAnchorElement>(".notice-title")!;
a.textContent = n.title;
Expand Down
Loading