Repository navigation
Conversation
Assigning to innerHTML is a Trusted Types injection sink, rejected even when the value is an empty string. textContent = '' clears children identically and is not a sink.
oioki
added a commit
to getsentry/sentry
that referenced
this pull request
Sep 23, 2026
zrender's canvas and SVG painters clear their root and helper nodes by assigning to innerHTML. Assigning to innerHTML is a Trusted Types injection sink, so every chart render and dispose is rejected on a page that sets `require-trusted-types-for 'script'`. All seven writes assign an empty string, so textContent is equivalent and clears the node the same way. The remaining innerHTML in svg-legacy/Painter.js is a read, not a write, and is left alone. Submitted upstream as ecomfe/zrender#1167. Patching locally until it lands, since charts are unusable under enforcement without it.
oioki
added a commit
to getsentry/sentry
that referenced
this pull request
Sep 23, 2026
zrender's canvas and SVG painters clear their root and helper nodes by assigning to `innerHTML`. That is a [Trusted Types](https://developer.mozilla.org/en-US/docs/Web/API/Trusted_Types_API) injection sink, so every chart render and dispose is rejected on a page that sets `require-trusted-types-for 'script'`. Charts are the single largest source of sinks we pull in (133 occurrences across echarts/zrender), and none of them are reachable from our own code. All seven writes assign an empty string, so `textContent = ''` is equivalent and clears the node the same way. The remaining `innerHTML` in `svg-legacy/Painter.js` is a read, not a write, and is left alone. Submitted upstream as [ecomfe/zrender#1167](ecomfe/zrender#1167). Patching locally until it lands — upstream acceptance is not on our timeline, and charts are unusable under enforcement without it. Verified: the 13 chart suites in `static/app/components/charts` pass (126 tests), and the patched files contain no remaining `innerHTML` writes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assigning to
innerHTMLis a Trusted Types injection sink. On a page sendingrequire-trusted-types-for 'script', the browser rejects the assignment even when the value is an empty string — so zrender throws indispose(), and on clip-path and gradient updates.textContent = ''clears children identically and is not a sink.svg/Painter.ts#clear()assignednull, relying on[LegacyNullToEmptyString]; it now assigns''.