Put testthat back in the CI dependency lists - #5
Merged
Merged
Conversation
Restricting the matrix and backends jobs to hard dependencies dropped
testthat along with the rest of Suggests. tests/testthat.R opens with
library(testthat), so the test stage errored instead of skipping.
_R_CHECK_FORCE_SUGGESTS_ = false does not cover this. It downgrades check's
complaint about absent Suggests to an INFO line; it does not stop R CMD check
from running the test file. The r-devel log listed testthat among
Packages suggested but not available for checking:
'sp', 'GWmodel', 'ranger', 'brms', 'cmdstanr', 'loo', 'geometry',
'gstat', 'patchwork', 'FNN', 'testthat'
and everything else on that list really is optional: no test file uses one
outside skip_if_not_installed(), and no example that actually runs -- i.e.
outside \dontrun{} -- uses one outside requireNamespace(). testthat was the
single entry that has to be installed for the check to proceed.
The vignette half of the previous commit was correct; that run reported
"creating vignettes ... OK", so knitr, rmarkdown and ggplot2 sufficed. It also
came in at 16m47s against the earlier 30m35s, so dropping the Stan toolchain
did what it was meant to.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014DkVoswUXWntSsYAJsxgPw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restricting the matrix and backends jobs to hard dependencies dropped testthat along with the rest of Suggests. tests/testthat.R opens with library(testthat), so the test stage errored instead of skipping.
R_CHECK_FORCE_SUGGESTS = false does not cover this. It downgrades check's complaint about absent Suggests to an INFO line; it does not stop R CMD check from running the test file. The r-devel log listed testthat among
and everything else on that list really is optional: no test file uses one outside skip_if_not_installed(), and no example that actually runs -- i.e. outside \dontrun{} -- uses one outside requireNamespace(). testthat was the single entry that has to be installed for the check to proceed.
The vignette half of the previous commit was correct; that run reported "creating vignettes ... OK", so knitr, rmarkdown and ggplot2 sufficed. It also came in at 16m47s against the earlier 30m35s, so dropping the Stan toolchain did what it was meant to.
Claude-Session: https://claude.ai/code/session_014DkVoswUXWntSsYAJsxgPw