Merged
Conversation
✅ Deploy Preview for ember-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
void-mAlex
reviewed
Mar 26, 2026
void-mAlex
reviewed
Mar 26, 2026
void-mAlex
approved these changes
Mar 27, 2026
Contributor
Author
|
I created a follow-up PR that simply removes ember-data-fastboot: #1194 That seems like the easiest and imo best solution. I don't think loading an extra json on the initial page load is that bad and it allows us to drop an addon that is not maintained, or having to maintain that code here. Since the end result of this repo is most likely a Vite + SSR setup it would have to be dropped eventually anyway. |
Closed
Member
|
I have simplified this PR by splitting out the lint fixes into their own PR #1197 to make it easier for me to review 👍 |
mansona
approved these changes
Mar 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the project to the latest Ember v4.12 blueprint and resolves any new linting errors.
I tried resolving all deprecations I encountered, but some of them are in addon code.
Remaining deprecations:
toArraydeprecation here. We could maybe patch it? Or inline the code in the repo? The package seems pretty unmaintained. I'm also not really sure we actually need it? Does it provide a huge benefit over fetching the data again in the frontend?ember-render-helpersdeprecation, but that shouldn''t block the v5 blueprint update in the future.Supersedes #1076