Skip to content

Update to Ember v4.12#1193

Merged
mansona merged 3 commits intoember-learn:mainfrom
Windvis:ember-4.12
Mar 27, 2026
Merged

Update to Ember v4.12#1193
mansona merged 3 commits intoember-learn:mainfrom
Windvis:ember-4.12

Conversation

@Windvis
Copy link
Copy Markdown
Contributor

@Windvis Windvis commented Mar 25, 2026

This updates the project to the latest Ember v4.12 blueprint and resolves any new linting errors.

I tried resolving all deprecations I encountered, but some of them are in addon code.

Remaining deprecations:

  • ember-data-fastboot triggers the toArray deprecation here. We could maybe patch it? Or inline the code in the repo? The package seems pretty unmaintained. I'm also not really sure we actually need it? Does it provide a huge benefit over fetching the data again in the frontend?
  • ember-leaflet triggers a ember-render-helpers deprecation, but that shouldn''t block the v5 blueprint update in the future.

Supersedes #1076

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 25, 2026

Deploy Preview for ember-website ready!

Name Link
🔨 Latest commit 0095849
🔍 Latest deploy log https://app.netlify.com/projects/ember-website/deploys/69c6a9ec3455f200087f36fb
😎 Deploy Preview https://deploy-preview-1193--ember-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Comment thread app/templates/community/meetups/index.hbs Outdated
Comment thread tests/integration/helpers/format-date-time-test.js Outdated
@Windvis
Copy link
Copy Markdown
Contributor Author

Windvis commented Mar 27, 2026

I created a follow-up PR that simply removes ember-data-fastboot: #1194

That seems like the easiest and imo best solution. I don't think loading an extra json on the initial page load is that bad and it allows us to drop an addon that is not maintained, or having to maintain that code here.

Since the end result of this repo is most likely a Vite + SSR setup it would have to be dropped eventually anyway.

@Windvis Windvis mentioned this pull request Mar 27, 2026
@mansona
Copy link
Copy Markdown
Member

mansona commented Mar 27, 2026

I have simplified this PR by splitting out the lint fixes into their own PR #1197 to make it easier for me to review 👍

@mansona mansona merged commit dd87283 into ember-learn:main Mar 27, 2026
5 checks passed
@mansona mansona mentioned this pull request Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants