Conversation
NullVoxPopuli
force-pushed
the
test-earlier-embers
branch
from
13bbefa to
d9b25ab
Compare
This reverts commit a6cc731.
NullVoxPopuli
force-pushed
the
test-earlier-embers
branch
from
a6cc731 to
ad75f5a
Compare
|
the "fix" (some macros code for accessing @glimmer/validator) isn't neeeded in this project. so that means
|
This reverts commit ad75f5a.
| scenarios: [ | ||
| { | ||
| name: 'ember-lts-5.8', | ||
| name: 'ember-lts-3.28', |
There was a problem hiding this comment.
I don't think 3.28 support is needed since it was dropped in v3?
There was a problem hiding this comment.
I don' think so? it just says ember-cli was updated?
There was a problem hiding this comment.
The description of PR #81 explicitly mentions that it drops support for ember < 4.12, which is why it was marked as breaking?
There was a problem hiding this comment.
ah ok, I was just reading the CHANGELOG.
But, it seems they dropped support only because the blueprint made it harder to support. It's very easy now
There was a problem hiding this comment.
Fair enough, but if you widen the range again I would also update the versions in the readme. It also mentions 4.12 at the moment 😄 .
2 participants
No description provided.