Skip to content

Test earlier embers #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NullVoxPopuli wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Test earlier embers #93

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
49ddf5f
Add support for earlier embers
NullVoxPopuli Apr 15, 2026
08149ea
Revert fix
NullVoxPopuli Apr 15, 2026
ad75f5a
Revert "Revert fix"
NullVoxPopuli Apr 15, 2026
0710684
Reapply "Revert fix"
NullVoxPopuli Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 32 additions & 2 deletions .try.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,24 @@ const compatDeps = {
export default {
scenarios: [
{
name: 'ember-lts-5.8',
name: 'ember-lts-3.28',
Copy link
Copy Markdown

@Windvis Windvis Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think 3.28 support is needed since it was dropped in v3?

Copy link
Copy Markdown
Contributor Author

@NullVoxPopuli NullVoxPopuli Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don' think so? it just says ember-cli was updated?

Copy link
Copy Markdown

@Windvis Windvis Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description of PR #81 explicitly mentions that it drops support for ember < 4.12, which is why it was marked as breaking?

Copy link
Copy Markdown
Contributor Author

@NullVoxPopuli NullVoxPopuli Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok, I was just reading the CHANGELOG.

But, it seems they dropped support only because the blueprint made it harder to support. It's very easy now

Copy link
Copy Markdown

@Windvis Windvis Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, but if you widen the range again I would also update the versions in the readme. It also mentions 4.12 at the moment 😄 .

npm: {
devDependencies: {
'ember-source': '~5.8.0',
'ember-source': '~3.28.0',
...compatDeps,
'ember-cli': '^4.12',
},
},
env: {
ENABLE_COMPAT_BUILD: true,
},
files: compatFiles,
},
{
name: 'ember-lts-4.12',
npm: {
devDependencies: {
'ember-source': '~4.12.0',
...compatDeps,
},
},
Expand Down Expand Up @@ -59,6 +73,22 @@ export default {
},
},
},
{
name: 'ember-lts-6.8',
npm: {
devDependencies: {
'ember-source': 'npm:ember-source@~6.8.0',
},
},
},
{
name: 'ember-lts-6.12',
npm: {
devDependencies: {
'ember-source': 'npm:ember-source@~6.12.0',
},
},
},
{
name: 'ember-latest',
npm: {
Expand Down
Loading