fix: publish root TypeScript declarations for CommonJS consumers#145
Open
bcornish1797 wants to merge 2 commits intoesatterwhite:mainfrom
Open
fix: publish root TypeScript declarations for CommonJS consumers#145bcornish1797 wants to merge 2 commits intoesatterwhite:mainfrom
bcornish1797 wants to merge 2 commits intoesatterwhite:mainfrom
Conversation
Owner
|
Thanks @bcornish1797 I'll try to get to this in the next day or so |
Owner
|
@bcornish1797 Can you rerun |
Author
|
Done — I ran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@algora-pbc /claim #135
This keeps the package CommonJS-first and avoids a build step, while making published typings usable from TypeScript NodeNext consumers.
What changed:
index.d.tssoimport seeli from "seeli"resolves declarations from the package entrypointfilesand pointpackage.json#typesat itrun()paths that can returnundefinedVerification:
npm testnpm run lint(warnings only from generated.tapreport files, no errors)npx tsc --pretty falsewithmodule=NodeNextrequire("seeli")import seeli from "seeli"This follows the maintainer guidance from #135: CommonJS-first, no TypeScript build step, and focused on publishable type definitions rather than rewriting the runtime to TS/ESM.