-
Notifications
You must be signed in to change notification settings - Fork 9
fix: publish root TypeScript declarations for CommonJS consumers #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
esatterwhite
merged 2 commits into
esatterwhite:main
from
bcornish1797:hermes/issue-135-types-entrypoint
Apr 24, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import Command = require('./lib/command') | ||
| import Seeli = require('./lib/seeli') | ||
|
|
||
| declare const seeli: Seeli & { | ||
| Seeli: typeof Seeli | ||
| Command: typeof Command | ||
| list: string[] | ||
| [key: string]: any | ||
| } | ||
|
|
||
| export = seeli |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,73 +1,22 @@ | ||
| import Command = require('./command') | ||
|
|
||
| /** | ||
| * Seeli Entrypoint used for registering and managing commands | ||
| * @module module:seeli/lib/seeli | ||
| * @author Eric Satterwhite | ||
| */ | ||
| declare class Seeli extends Command { | ||
| /** | ||
| * Get configuration value | ||
| * @param args Arguments to pass to config.get | ||
| */ | ||
| static get(...args: any[]): any; | ||
|
|
||
| /** | ||
| * Set configuration value | ||
| * @param args Arguments to pass to config.set | ||
| */ | ||
| static set(...args: any[]): any; | ||
|
|
||
| /** | ||
| * Colorize text with a specific color | ||
| * @param txt Text to colorize | ||
| * @param color Color to use | ||
| */ | ||
| static colorize(txt: string, color: string): string; | ||
|
|
||
| /** | ||
| * Get the Command class | ||
| */ | ||
| static get Command(): typeof Command; | ||
|
|
||
| /** | ||
| * Get the Command class | ||
| */ | ||
| get Command(): typeof Command; | ||
|
|
||
| /** | ||
| * Constructor for Seeli class | ||
| * @param args Arguments to pass to the constructor | ||
| */ | ||
| constructor(...args: any[]); | ||
|
|
||
| /** | ||
| * Colorize text with a specific color | ||
| * @param txt Text to colorize | ||
| * @param color Color to use | ||
| */ | ||
| colorize(txt: string, color: string): string; | ||
|
|
||
| /** | ||
| * Get or set configuration values | ||
| * @param args Arguments to pass to config | ||
| */ | ||
| config(...args: any[]): any; | ||
|
|
||
| /** | ||
| * Run the Seeli application | ||
| */ | ||
| run(): void; | ||
|
|
||
| /** | ||
| * Reset the Seeli instance | ||
| */ | ||
| run(...args: any[]): Promise<any> | undefined; | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hm. I don't know if that is true that it would return |
||
| reset(): Seeli; | ||
|
|
||
| /** | ||
| * Load plugins | ||
| * @param args Plugin arguments | ||
| */ | ||
| plugin(...args: any[]): Seeli; | ||
| } | ||
|
|
||
| export = Seeli; | ||
|
|
||
| export = Seeli | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bcornish1797 out of curiosity, why remove the comments?