Skip to content

Fix Coveralls race between matrix legs #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mr-git merged 1 commit into from
Aug 24, 2026
Merged

Fix Coveralls race between matrix legs #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ jobs:
file: ${{ steps.coverage.outputs.file }}
format: cobertura
flag-name: Scala ${{ matrix.scala }}
parallel: true

# Scanned once, on the first Scala version only: SonarQube tracks one analysis per branch, so
# running it per matrix leg would have the legs overwrite each other.
Expand Down Expand Up @@ -191,6 +192,20 @@ jobs:
-Dsonar.scala.coverage.reportPaths=${{ steps.sonar.outputs.reports }}
${{ inputs.sonar_args }}

# Closes the parallel Coveralls build once every matrix leg has uploaded its part. Without
# `parallel: true` the first upload closes the build and the other legs get rejected with
# "Can't add a job to a build that is already closed".
coverage-finished:
runs-on: ubuntu-latest
needs: [test-coverage]
if: ${{ !cancelled() }}

steps:
- name: finish Coveralls build
uses: coverallsapp/github-action@v2
with:
parallel-finished: true

binary-compatibility:
runs-on: ubuntu-latest
strategy:
Expand Down