fix: Return 400 for malformed request bodies#110
Merged
Conversation
thced
force-pushed
the
fix/invalid-json
branch
2 times, most recently
from
c18e988 to
3b30ebd
Compare
An unparseable request body (e.g. a double comma in JSON) made the body mapper throw its library-specific runtime exception, which fell through to the default 500 branch of the exception handler. Convert any parse failure at the single mapper.readFrom call site into a ValidationException so it renders as a 400 application/problem+json response, consistent with the other body-validation errors. Covers all body mappers.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unparseable request body (e.g. a double comma in JSON) made the body mapper throw its library-specific runtime exception, which fell through to the default 500 branch of the exception handler.
Convert any parse failure at the single mapper.readFrom call site into a ValidationException so it renders as a 400 application/problem+json response, consistent with the other body-validation errors. Covers all body mappers.