fix: Drop TypeMapper from healthHandler and derive up from dependencies#76
Merged
Conversation
healthHandler no longer requires a TypeMapper — the fixed wire shape is rendered by a built-in JSON writer with proper string escaping, so the health endpoint works without a JSON library on the classpath. HealthOutcome's up flag is now derived: empty dependencies report as up, otherwise up is the conjunction of every dependency's status.
thced
force-pushed
the
fix/no-typemapper-health
branch
from
d5a98b6 to
087acc3
Compare
Covers control-char escaping (named and \u####), multi-dependency ordering, and pass-through of non-ASCII characters — paths the handler test only exercises indirectly.
sasjo
approved these changes
May 20, 2026
|
thced
added a commit
that referenced
this pull request
May 20, 2026
Mirror PR #76's approach (HealthRenderer) for the problem+json wire shape. The default exception handler and SecurityFilter no longer route ProblemDetail through a TypeMapper; a hand-rolled ProblemDetailRenderer writes the fixed RFC 7807 shape directly, so the library emits problem responses without a JSON library on the classpath and without record-accessor reflection that GraalVM Native Image would otherwise need configured. Also replace the reflective GsonJsonMapper newInstance with a direct constructor call, still gated by the existing Class.forName Gson-presence probe. Drops the matching reflect-config entry for the constructor. Extract the shared JSON string-escape into internal/JsonStrings, used by both HealthRenderer and ProblemDetailRenderer. BREAKING CHANGE: Handlers.defaultExceptionHandler(TypeMapper) becomes defaultExceptionHandler(). SecurityFilter constructor drops its TypeMapper parameter.
thced
added a commit
that referenced
this pull request
May 21, 2026
Mirror PR #76's approach (HealthRenderer) for the problem+json wire shape. The default exception handler and SecurityFilter no longer route ProblemDetail through a TypeMapper; a hand-rolled ProblemDetailRenderer writes the fixed RFC 7807 shape directly, so the library emits problem responses without a JSON library on the classpath and without record-accessor reflection that GraalVM Native Image would otherwise need configured. Also replace the reflective GsonJsonMapper newInstance with a direct constructor call, still gated by the existing Class.forName Gson-presence probe. Drops the matching reflect-config entry for the constructor. Extract the shared JSON string-escape into internal/JsonStrings, used by both HealthRenderer and ProblemDetailRenderer. BREAKING CHANGE: Handlers.defaultExceptionHandler(TypeMapper) becomes defaultExceptionHandler(). SecurityFilter constructor drops its TypeMapper parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
healthHandler no longer requires a TypeMapper — the fixed wire shape is rendered by a built-in JSON writer with proper string escaping, so the health endpoint works without a JSON library on the classpath.
HealthOutcome's up flag is now derived: empty dependencies report as up, otherwise up is the conjunction of every dependency's status.