fix: Run response decorators inside interceptor ScopedValue scope#98
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
DispatchHandler.invoke(...)so decorators execute inside everyRequestInterceptor'sScopedValuescope. Honors the contract documented in README "Combining the two" — previously a decorator that calledCORRELATION_ID.get()threwNoSuchElementExceptionbecause the interceptor's scope had already unwound.Responseon the way back up the stack (a tracing interceptor wrappingnext.proceed()sees the final status, headers, and body).try/catcharoundnext.proceed()will observe decorator failures. Documented in README.Changes
DispatchHandler.handle/invokerefactor (one method-pair, ~7 lines).ResponseDecoratorjavadoc cross-referencesRequestInterceptor+ScopedValuevisibility.DispatchHandlerTest+ one IT inDecoratorAndInterceptorIT.Spec:
docs/superpowers/specs/2026-05-23-decorator-scoped-value-scope-design.mdPlan:
docs/superpowers/plans/2026-05-23-decorator-scoped-value-scope.mdTest plan
ScopedValueand stamps a headernext.proceed()returns the decorator-modifiedResponsetry/catcharoundnext.proceed()catches a throwing decorator; final response carries the catch-block statusOpenApiServer— decorator readsTENANTbound by interceptor, stampsX-Tenant-Idmvn verifypasses (475 unit + 68 IT, 0 failures)DispatchHandler