fix(firestore-send-email): improve attachments validation error message (rebased)#2783
Draft
IzaakGough wants to merge 11 commits intonextfrom
Draft
fix(firestore-send-email): improve attachments validation error message (rebased)#2783IzaakGough wants to merge 11 commits intonextfrom
IzaakGough wants to merge 11 commits intonextfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves error messaging for the attachments field by providing more descriptive feedback when the field is not an array and updating the formatZodError function to handle custom messages and missing fields. A review comment suggests refining the error formatting logic to be more generic, fixing grammatical issues in generated messages, and maintaining terminology consistency by using the term map instead of object.
IzaakGough
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2550
supersedes #2583