-
Notifications
You must be signed in to change notification settings - Fork 429
fix(firestore-send-email): improve attachments validation error message (rebased) #2783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
IzaakGough
wants to merge
11
commits into
next
Choose a base branch
from
rebased-@invertase/improve-email-attachment-error-message
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5c84c34
fix(firestore-send-email): improve attachments validation error message
HassanBahati 6401197
fix(firestore-send-email): improve attachments validation error message
HassanBahati 428ab00
tests(firestore-send-email): fix tests
HassanBahati 78ed835
tests(firestore-send-email): fix tests
HassanBahati 2907039
tests(firestore-send-email): refactor tests
HassanBahati 6f2dc3d
tests(firestore-send-email): fix tests
HassanBahati 4f5dfb6
tests(firestore-send-email): refactor tests
HassanBahati 5b812c4
refactor: improve invalid_type case handling
IzaakGough 8b78274
chore: fix typo
IzaakGough 7530f00
tests: fix test
IzaakGough dc5a69a
fix: remove unnecessary check
IzaakGough File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.