fix: make --objective optional for alexandria feedback - #301
Merged
Merged
Conversation
1.25.1 made --objective a required option, so feedback from agents using skill copies without it failed before sending, and the recommended --silent & pattern hid the error. The API already accepts feedback without an objective. Bump to 1.25.3. Co-authored-by: Cursor <cursoragent@cursor.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 4 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. Makes --objective optional for alexandria feedback, restoring pre-1.25.1 behavior after a required-option regression; tests show feedback is sent without the field and blank values are still rejected, with README and version updated.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Alexandria feedback volume dropped from Sept 30. #292 (released in 1.25.1) made
--objectivearequiredOptiononfirecrawl alexandria feedback. Agents running skill copies written before that flag existed omit it, so the command exits before sending, and the recommended--silent &pattern hides the error. The API (firecrawl/firecrawl#4877) deliberately accepts feedback without an objective.Change
--objectiveis now a regular option; it is still trimmed and rejected when blank, and still shown in the skill example.--objectiveis sent (without the field); a blank value is still rejected.Testing
pnpm build && vitest run src/__tests__/alexandria-beta.test.ts src/__tests__/commands/feedback.test.ts: 70/70 pass.Made with Cursor
Summary by cubic
Restores compatibility with agents on older skill copies by making
--objectiveoptional forfirecrawl alexandria feedback. 1.25.1 required the flag, so the command exited before sending when it was omitted, and the recommended--silent &pattern hid the failure. The API already accepts feedback without an objective.Blank values are still trimmed and rejected before sending. The flag stays in the skill example and README (now noted as optional). Version bumped to 1.25.3.
Written for commit f941fca. Summary will update on new commits.