Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1052,4 +1052,4 @@ firecrawl alexandria feedback --rating partial \
--rationale "Found summaries but could not retrieve attachments" --json
```

`--objective` is the underlying goal of the session: what you or your user were ultimately trying to accomplish, beyond the single website. No job ID is required. Alexandria session feedback has no job-age deadline and does not refund credits. Optional `--provider-feedback` and `--capability-feedback` accept JSON arrays; see `firecrawl alexandria feedback --help` for their fields and issue codes. Capability issue codes are `new_capability_request` (requires `requestedFunctionality`), `missing_capability` (the provider exists but lacks this capability), `insufficient_functionality`, `incorrect_result`, `execution_error`, and `other`. Existing `feedback` and `search-feedback` commands retain their job-specific behavior. Endpoint feedback opt-out environment variables also apply to this command.
The optional `--objective` is the underlying goal of the session: what you or your user were ultimately trying to accomplish, beyond the single website. No job ID is required. Alexandria session feedback has no job-age deadline and does not refund credits. Optional `--provider-feedback` and `--capability-feedback` accept JSON arrays; see `firecrawl alexandria feedback --help` for their fields and issue codes. Capability issue codes are `new_capability_request` (requires `requestedFunctionality`), `missing_capability` (the provider exists but lacks this capability), `insufficient_functionality`, `incorrect_result`, `execution_error`, and `other`. Existing `feedback` and `search-feedback` commands retain their job-specific behavior. Endpoint feedback opt-out environment variables also apply to this command.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "firecrawl-cli",
"version": "1.25.2",
"version": "1.25.3",
"publishConfig": {
"tag": "latest"
},
Expand Down
12 changes: 9 additions & 3 deletions src/__tests__/alexandria-beta.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1567,14 +1567,20 @@ const sessionFeedbackArgs = [
'Missing documents',
];

it('requires a non-blank objective before sending feedback', async () => {
it('sends session feedback without an objective', async () => {
response = { success: true, feedbackId: 'feedback-1', creditsRefunded: 0 };
const index = sessionFeedbackArgs.indexOf('--objective');
const withoutObjective = sessionFeedbackArgs.filter(
(_, i) => i !== index && i !== index + 1
);
expect((await cli(withoutObjective)).code).not.toBe(0);
expect((await cli(withoutObjective)).code).toBe(0);
expect(requests).toHaveLength(1);
expect(requests[0].body).not.toHaveProperty('objective');
});

it('rejects a blank objective before sending feedback', async () => {
const blank = [...sessionFeedbackArgs];
blank[index + 1] = ' ';
blank[sessionFeedbackArgs.indexOf('--objective') + 1] = ' ';
expect((await cli(blank)).code).not.toBe(0);
expect(requests).toHaveLength(0);
});
Expand Down
2 changes: 1 addition & 1 deletion src/commands/alexandria-feedback.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ export function createAlexandriaFeedbackCommand(): Command {
'What you needed from the website',
detail
)
.requiredOption(
.option(
'--objective <text>',
'The underlying goal: what you or your user were ultimately trying to accomplish',
detail
Expand Down
Loading