feat(nginx): Cache static assets at the proxy, opt-in per domain#179
Merged
Conversation
A deployment can now let the proxy set a long browser cache on its static assets (styles, scripts, images, fonts). It is off by default and enabled per domain. The cache applies only to responses whose path has a static extension, keyed off the request path, so dynamic and API responses are untouched and keep whatever cache headers the app already sets. Turning it on serves a repeat visitor's static files from their browser instead of re-fetching them through the proxy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A deployment can now let the proxy set a long browser cache on its static assets (styles, scripts, images, fonts). It is off by default and enabled per domain.
The cache is keyed off the request path's extension, so it applies only to static files; dynamic and API responses are untouched and keep whatever cache headers the app already sets. Verified against real nginx: a
.cssresponse gets a 30-dayCache-Control, while a dynamic path that set its ownno-storekept it.This closes the serving-performance audit item on #158. The proxy-overhead baseline from that item, measured with keepalive pooling in place: the proxy adds about 0.05ms mean over hitting the container directly (p50 0.04 to 0.09ms, p95 0.07 to 0.17ms on loopback), so the proxy's own cost is negligible and not a bottleneck.
UI counterpart: flatrun/ui#85.