feat(ui): Add a static-asset caching toggle to the domain form#85
Merged
Conversation
A domain can now opt into a long browser cache for its static assets. The toggle is off by default; it only affects static files, so dynamic responses keep the app's own cache headers.
Code Review SummaryThis PR introduces a new 🚀 Key Improvements
💡 Minor Suggestions
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
| static_cache: true, | ||
| }); | ||
|
|
||
| document.querySelector<HTMLButtonElement>(".btn-primary")?.click(); |
There was a problem hiding this comment.
Using document.querySelector is slightly brittle and bypasses the Vue Test Utils wrapper. It's more idiomatic to use wrapper.find to target the button.
Suggested change
| document.querySelector<HTMLButtonElement>(".btn-primary")?.click(); | |
| await wrapper.find(".btn-primary").trigger("click"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A domain can now opt into a long browser cache for its static assets. The toggle is off by default and only affects static files, so dynamic responses keep the app's own cache headers.
Pairs with the agent-side caching support: flatrun/agent#179.