Skip to content

ci: ignore material.dart deprecation per import - #1062

Merged
polina-c merged 2 commits into
flutter:mainfrom
polina-c:ignore-material-deprecation
Oct 15, 2026
Merged

polina-c merged 2 commits into
flutter:mainfrom
polina-c:ignore-material-deprecation

Conversation

@polina-c

@polina-c polina-c commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Follow-up to #1058, as suggested in #1058 (comment).

#1058 made infos non-fatal on beta so that the package:flutter/material.dart deprecation wouldn't fail analysis. That turns off every other info on beta too, and it would have to be extended to stable once the deprecation ships there.

This restores flutter analyze --fatal-infos on both channels and instead ignores deprecated_member_use on each import 'package:flutter/material.dart'; (85 imports across packages/genui, examples/simple_chat, examples/verdure/client, dev_tools/catalog_gallery and dev_tools/composer):

// TODO(https://github.com/a2ui-project/a2ui/issues/3235): Migrate to material_ui.
// ignore: deprecated_member_use
import 'package:flutter/material.dart';

Migrating to package:material_ui still isn't an option, since it requires Flutter 3.47 and genui supports 3.35.7. The cleanup is tracked in a2ui-project/a2ui#3235.

@polina-c polina-c changed the title Ci3 ci: ignore material.dart deprecation per import Oct 15, 2026
@polina-c
polina-c requested a review from ditman October 15, 2026 18:21

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds TODO comments and deprecation ignore annotations to Flutter material imports across multiple files to prepare for a migration to material_ui. However, the added '// ignore: deprecated_member_use' comments are unnecessary and ineffective because importing material.dart does not trigger deprecation warnings, and line-level ignores in Dart only apply to the line immediately following them. It is recommended to remove these redundant ignore comments or use file-level ignores if deprecated members are actually used elsewhere in the files.

Comment thread packages/genui/lib/src/widgets/surface.dart Outdated
Comment thread packages/genui/lib/src/model/catalog.dart Outdated
Comment thread examples/simple_chat/lib/main.dart Outdated

@ditman ditman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this so quickly, if CI is happy, I'm happy too!

Comment thread dev_tools/catalog_gallery/integration_test/app_test.dart Outdated
@polina-c
polina-c merged commit 584d103 into flutter:main Oct 15, 2026
40 checks passed
@polina-c
polina-c deleted the ignore-material-deprecation branch October 15, 2026 19:36
@ditman

ditman commented Oct 15, 2026

Copy link
Copy Markdown
Member

I just realized that we need this too in the a2ui repo. I'll send a similar PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants