Skip to content

ci: don't fail beta analysis on infos - #1058

Merged
gspencergoog merged 1 commit into
flutter:mainfrom
polina-c:ci-beta-nonfatal-infos
Oct 15, 2026
Merged

gspencergoog merged 1 commit into
flutter:mainfrom
polina-c:ci-beta-nonfatal-infos

Conversation

@polina-c

@polina-c polina-c commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes a2ui-project/a2ui#3229.

Flutter beta deprecates package:flutter/material.dart in favor of package:material_ui. With flutter analyze --fatal-infos, every package that imports material.dart fails analysis on beta, regardless of what a PR changes (for example #1057).

Migrating to material_ui isn't an option yet: it requires Flutter 3.47, and genui supports 3.35.7.

This keeps --fatal-infos on stable and passes --no-fatal-infos on beta, so infos still show in beta logs without failing the job. Warnings and errors stay fatal on both channels.

Flutter beta deprecates package:flutter/material.dart in favor of
package:material_ui, which needs Flutter 3.47 and so can't be adopted
while genui supports 3.35. With --fatal-infos, that fails analysis of
every package importing material.dart on beta. Keep infos fatal on
stable only.
@gspencergoog
gspencergoog merged commit 5dbdeee into flutter:main Oct 15, 2026
43 checks passed
@ditman

ditman commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

This is a good emergency fix after a flutter update, but when flutter beta becomes stable we'll be forced to suppress the fatal infos for that too.

The error is:

   info • 'package:flutter/material.dart' is deprecated and shouldn't be used. Use package:material_ui/material_ui.dart instead. This feature was deprecated after v3.47.0-0.0.pre. Try replacing the use of the deprecated member with the replacement • test/widgets/widget_utilities_test.dart:5:1 • deprecated_member_use

Could we add //ignore: deprecated_member_use above the offending import 'package:flutter/material.dart' lines? (I know there's a bunch, but that way we don't disable all the fatal infos elsewhere?)

(Having the //ignore lines would also be a very good place to add a link to a GH issue describing the cleanup that needs to happen)

@polina-c

Copy link
Copy Markdown
Collaborator Author

This is a good emergency fix after a flutter update, but when flutter beta becomes stable we'll be forced to suppress the fatal infos for that too.

The error is:

   info • 'package:flutter/material.dart' is deprecated and shouldn't be used. Use package:material_ui/material_ui.dart instead. This feature was deprecated after v3.47.0-0.0.pre. Try replacing the use of the deprecated member with the replacement • test/widgets/widget_utilities_test.dart:5:1 • deprecated_member_use

Could we add //ignore: deprecated_member_use above the offending import 'package:flutter/material.dart' lines? (I know there's a bunch, but that way we don't disable all the fatal infos elsewhere?)

(Having the //ignore lines would also be a very good place to add a link to a GH issue describing the cleanup that needs to happen)

Thank you! Follow up: #1062

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

genui CI: bots fail at main of genui

3 participants