Skip to content

fix(dashboard): scroll the page itself - #18

Merged
anilcancakir merged 1 commit into
mainfrom
fix/dashboard-scrolls-itself
Sep 24, 2026
Merged

anilcancakir merged 1 commit into
mainfrom
fix/dashboard-scrolls-itself

Conversation

@anilcancakir

Copy link
Copy Markdown
Member

What

  • DashboardView wraps its content in SingleChildScrollView(primary: false).

Why

fluttersdk/magic_starter#166 changes the app shell's default content box so it no longer scrolls; a scroll around the shell's nested Navigator broke a page left under a stacked route (fluttersdk/magic_starter#160). Under the new default a page taller than the window has to scroll itself, and this one had no scroll of its own. Under the current default the inner scroll sizes to its content and never claims a drag, so this is safe to land before or after the starter change.

Testing

  • flutter analyze clean, 30 tests green.

magic_starter's app shell stops scrolling its content box
(fluttersdk/magic_starter#166): a scroll around the shell's nested
Navigator broke a page left under a stacked route. Under the new
default a page taller than the window scrolls itself, and this one had
no scroll of its own. Under the old default the inner scroll sizes to
its content and claims no drag, so this lands safely either way.
@kodizm

kodizm Bot commented Sep 24, 2026

Copy link
Copy Markdown

Note

Kodizm (AI-generated). May contain mistakes; verify before acting.

Small, well-reasoned fix; looks correct as a static change.

Minor

lib/resources/views/dashboard_view.dart:100: the PR's testing note only cites flutter analyze and flutter test, but AGENTS.md requires anything a person clicks or scrolls to be driven for real with fluttersdk_dusk at both desktop and mobile width, per docs/verification-loop.md. A scroll fix is exactly the kind of change that can look right statically and still misbehave at runtime (for example if the app shell's content box still claims the drag in some viewport), so it's worth confirming with an actual dusk pass at both widths before merging.

Tests

No new automated test covers the scroll behaviour; none of the 30 existing tests target DashboardView's layout, so this rests on manual/dusk verification per repo convention, which the PR description doesn't confirm was done.

CI

Flutter (analyze + test): success. Backend (pint + tests): success. Design tokens: success. Instruction mirrors: success. Published graph (hosted resolution): success. Auto-merge low-risk Dependabot PRs: skipped (not applicable). Overall: success.

@anilcancakir

Copy link
Copy Markdown
Member Author

Walked it with dusk against a running Chrome, built on fluttersdk/magic_starter#166's non-scrolling content box (the case this PR exists for):

  • Desktop, 1440x520: the dashboard scrolls with the mouse wheel down to the footer, and the header leaves the top of the window.
  • Mobile, 390x600: it scrolls to the footer above the bottom tab bar, and the top bar stays in place.
  • dusk:exceptions: 0 across both widths.

Separately, and not this PR's concern: /notifications shows "Failed to load notifications" because the example backend registers no api/v1/notifications route (404, and route:list --path=notifications is empty). That is the case on main as well.

@anilcancakir
anilcancakir merged commit e50314f into main Sep 24, 2026
7 checks passed
@anilcancakir
anilcancakir deleted the fix/dashboard-scrolls-itself branch September 24, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant