fix(dashboard): scroll the page itself - #18
Conversation
magic_starter's app shell stops scrolling its content box (fluttersdk/magic_starter#166): a scroll around the shell's nested Navigator broke a page left under a stacked route. Under the new default a page taller than the window scrolls itself, and this one had no scroll of its own. Under the old default the inner scroll sizes to its content and claims no drag, so this lands safely either way.
|
Note Kodizm (AI-generated). May contain mistakes; verify before acting. Small, well-reasoned fix; looks correct as a static change. Minor
TestsNo new automated test covers the scroll behaviour; none of the 30 existing tests target CI
|
|
Walked it with dusk against a running Chrome, built on fluttersdk/magic_starter#166's non-scrolling content box (the case this PR exists for):
Separately, and not this PR's concern: |
What
DashboardViewwraps its content inSingleChildScrollView(primary: false).Why
fluttersdk/magic_starter#166 changes the app shell's default content box so it no longer scrolls; a scroll around the shell's nested Navigator broke a page left under a stacked route (fluttersdk/magic_starter#160). Under the new default a page taller than the window has to scroll itself, and this one had no scroll of its own. Under the current default the inner scroll sizes to its content and never claims a drag, so this is safe to land before or after the starter change.
Testing
flutter analyzeclean, 30 tests green.