Skip to content

fix(dashboard): scroll the page itself #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anilcancakir merged 1 commit into from
Sep 24, 2026
Merged

fix(dashboard): scroll the page itself #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions lib/resources/views/dashboard_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,18 @@ class _DashboardViewState
Widget build(BuildContext context) {
final appName = Config.get('app.name', 'My App') ?? 'My App';

return WDiv(
className: 'w-full max-w-[480px] md:max-w-4xl mx-auto p-4 lg:p-8',
child: controller.renderState(
(name) => _buildLoaded(appName: appName, greetingName: name),
onLoading: _buildSkeleton(),
// Its own scroll: magic_starter's app shell stopped scrolling its content
// box (a scroll around the shell's nested Navigator broke a page left
// under a stacked route), so a page taller than the window scrolls
// itself. `primary: false`, as MSPageScaffold does.
return SingleChildScrollView(
primary: false,
child: WDiv(
className: 'w-full max-w-[480px] md:max-w-4xl mx-auto p-4 lg:p-8',
child: controller.renderState(
(name) => _buildLoaded(appName: appName, greetingName: name),
onLoading: _buildSkeleton(),
),
),
);
}
Expand Down
Loading