Stage1a template code#51
Merged
Merged
Conversation
|
🌐 Preview URL: https://pr-51.frcsoftware.pages.dev |
zachwaffle4
requested changes
Jun 30, 2026
zachwaffle4
left a comment
zachwaffle4
left a comment
Member
There was a problem hiding this comment.
This should be moved to examples/stage1/templates/ctre.
DylanB5402
reviewed
Jun 30, 2026
samfreund
force-pushed
the
main
branch
2 times, most recently
from
554cf11 to
449353a
Compare
this avoids the problem of depending on some random person's docker container
this avoids the problem of depending on some random person's docker container
Daniel1464
requested changes
Jul 1, 2026
Daniel1464
reviewed
Jul 1, 2026
Daniel1464
left a comment
Daniel1464
left a comment
Contributor
There was a problem hiding this comment.
Pretty much good, just have a few nitpicks
Daniel1464
previously approved these changes
Jul 2, 2026
DylanB5402
previously approved these changes
Jul 4, 2026
DylanB5402
left a comment
DylanB5402
left a comment
Member
There was a problem hiding this comment.
Code looks good! Anything else needed to get this merged in?
Adrianamm
previously approved these changes
Jul 4, 2026
zachwaffle4
requested changes
Jul 4, 2026
zachwaffle4
left a comment
zachwaffle4
left a comment
Member
There was a problem hiding this comment.
Can you please set up Copybara configuration in copy.bara.sky and the corresponding GitHub action? It should be relatively intuitive to add the new repos (https://github.com/frcsoftware/Stage1-Template-REV and https://github.com/frcsoftware/Stage1-Template-CTRE), but if not I can do it in a separate PR.
Also, can you add READMEs to the template roots?
Spaceman113138
dismissed stale reviews from Adrianamm, DylanB5402, and Daniel1464
via
3e08887
Daniel1464
approved these changes
Jul 5, 2026
zachwaffle4
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I copied the stage 1a solution code and removed all the the code students are expected to write as part of 1a. Almost everything got removed except for the simulation classes.
Closes #28 and #26