[repo-assist] refactor+test: extract compileSingleRefOrNewObject helper; add text/plain body, octet-stream response, path-level param tests (+ [Content truncated due to length]

[github-actions]

🤖 This PR was created by Repo Assist, an automated AI assistant.

Summary

Two changes in one PR: a targeted refactoring in DefinitionCompiler.fs and 9 new unit tests.

Task 5 — Refactor: extract compileSingleRefOrNewObject helper

compileBySchema contained three match arms for allOf/oneOf/anyOf single-$ref collapse that each had an identical 4-line inner match expression:

match schemas.[0] with
| :? OpenApiSchemaReference as schemaRef when not(isNull schemaRef.Reference) ->
    ns.ReleaseNameReservation tyName
    compileByPath <| getFullPath schemaRef.Reference.Id
| _ -> compileNewObject()

This is now extracted into a local compileSingleRefOrNewObject helper. The guards and semantics are unchanged — each arm still fires under the same conditions as before. The result is ~18 fewer lines of duplicated code and a clearer signal that the three arms share the same collapsing logic.

Task 10 — Tests: three untested OperationCompiler behaviours

Scenario	What's tested
text/plain request body	Method generates; body param is named textPlain; CT is last
application/octet-stream response	Method generates; return type is Task<IO.Stream>; CT is only param
Path-level parameters (on PathItem)	userId inherited by both GET and POST operations on the same path

These cover real-world API patterns (file download, plain-text echo, resource-scoped sub-collections) that were previously exercised by integration tests only.

Test Status

Total: 474, Errors: 0, Failed: 0, Skipped: 1, Time: 1.087s

All 474 tests pass (465 before → 474 after). Format check passes (dotnet fantomas --check).

Generated by 🌈 Repo Assist, see workflow run. Learn more.

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@dcdf09723d42ef9b6c75335e4612fd145d4ccdaa

Generated by 🌈 Repo Assist, see workflow run. Learn more.

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@dcdf09723d42ef9b6c75335e4612fd145d4ccdaa

[Copilot]

Pull request overview

Refactors three duplicated match arms in DefinitionCompiler.compileBySchema into a single local helper compileSingleRefOrNewObject, and adds nine new unit tests in Schema.OperationCompilationTests.fs covering text/plain request bodies, application/octet-stream responses, and path-level (PathItem-inherited) parameters.

Changes:

• Extract identical 4-line $ref-collapse logic from allOf/oneOf/anyOf arms into a local helper.
• Add tests for text/plain request body shape (method, parameter name, CancellationToken position).
• Add tests for octet-stream response (Task<IO.Stream> return type) and path-level parameter inheritance across GET/POST.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/SwaggerProvider.DesignTime/DefinitionCompiler.fs	Introduce compileSingleRefOrNewObject helper and use it in the three single-$ref collapse arms.
tests/SwaggerProvider.Tests/Schema.OperationCompilationTests.fs	Add 9 tests covering text/plain bodies, octet-stream responses, and path-level parameters.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[sergey-tihon]

@copilot fix the build

[Copilot]

@copilot fix the build

I pushed a build-fix commit e88ebf5 that switches generated property accessors to typed field expressions (Expr.FieldGet/Expr.FieldSet) instead of unchecked variants in DefinitionCompiler. This is now validated locally with format check + 474 unit tests passing, and automated review/CodeQL checks are clean.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• petstore.swagger.io
  • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet /usr/share/dotnet/sdk/10.0.300/FSharp/fsc.dll @/tmp/MSBuildTempUZB569/tmp6fca80bfc966468a8cd66035ce2fec65.rsp (dns block)
  • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet /usr/share/dotnet/sdk/10.0.300/FSharp/fsc.dll @/tmp/MSBuildTempU0djT9/tmp6f1fe6f60096479d9eafe70a3941957b.rsp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)