Skip to content

Remove --group-by-team-prefix-consolidate and consolidateTeamHierarchy - #198

Draft
shouze wants to merge 1 commit into
feat/team-hierarchy-docsfrom
feat/team-hierarchy-remove-consolidate
Draft

Remove --group-by-team-prefix-consolidate and consolidateTeamHierarchy#198
shouze wants to merge 1 commit into
feat/team-hierarchy-docsfrom
feat/team-hierarchy-remove-consolidate

Conversation

@shouze

@shouze shouze commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Removes --group-by-team-prefix-consolidate and consolidateTeamHierarchy end-to-end. After using it in practice, this consolidated-rendering mode did not match the actual functional need — the real pain point is resolving ambiguous combined sections (e.g. "gamme-lead-client + gamme-lead-client-p1") one by one via --pick-team, not the visual density of unambiguous single-branch chains. This option is superseded by --pick-team-auto (#199).

  • github-code-search.ts: removed the CLI option, the groupByTeamPrefixConsolidate field, the consolidateApplied computation and its --format json warning, and the consolidateTeamHierarchy import/call.
  • src/group.ts: removed consolidateTeamHierarchy and consolidateNode. Kept assignLevels / pruneEmptyChildren — still used by nestOverlappingLabels / groupByTeamHierarchy.
  • src/output.ts / src/tui.ts: removed consolidateTeamSections from ReplayOptions, buildReplayCommand, buildOutput, and runInteractive.
  • src/completions.ts: removed the completion entry.
  • Docs: removed the "Advanced: consolidated rendering" section and the CLI option row.
  • CHANGELOG.md: updated the pending v2.0.0 summary.

Closes #196.

How did you verify your code works?

  • bun test (977 passing), bun run lint, bun run format:check, bun run knip, bun run build.ts all green.
  • Verified no dangling references via grep -ri consolidat across the repo.

Superseded by --pick-team-auto (#197): the consolidated-rendering
mode does not match the actual functional need, which is reducing
manual --pick-team busywork on ambiguous combined sections, not
collapsing unambiguous single-branch chains.

Closes #196
@github-actions

Copy link
Copy Markdown

🔦 Lighthouse Report

Page ⚡ Perf ♿ A11y 🛡️ BP 🔍 SEO Report
/github-code-search/getting-started/ 🟢 99 (≥96) 🟢 100 (≥99) 🟢 100 (≥99) 🟢 100 (≥99) 🔗 view
/github-code-search/ 🟢 96 (≥96) 🟢 100 (≥99) 🟢 100 (≥99) 🟢 100 (≥99) 🔗 view

Thresholds: Perf ≥ 96 · A11y ≥ 99 · BP ≥ 99 · SEO ≥ 99
commit 9447c52 · full workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[8/9] Remove --group-by-team-prefix-consolidate and consolidateTeamHierarchy

1 participant