Remove --group-by-team-prefix-consolidate and consolidateTeamHierarchy - #198
Draft
shouze wants to merge 1 commit into
Draft
Remove --group-by-team-prefix-consolidate and consolidateTeamHierarchy#198shouze wants to merge 1 commit into
shouze wants to merge 1 commit into
Conversation
🔦 Lighthouse Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes
--group-by-team-prefix-consolidateandconsolidateTeamHierarchyend-to-end. After using it in practice, this consolidated-rendering mode did not match the actual functional need — the real pain point is resolving ambiguous combined sections (e.g."gamme-lead-client + gamme-lead-client-p1") one by one via--pick-team, not the visual density of unambiguous single-branch chains. This option is superseded by--pick-team-auto(#199).github-code-search.ts: removed the CLI option, thegroupByTeamPrefixConsolidatefield, theconsolidateAppliedcomputation and its--format jsonwarning, and theconsolidateTeamHierarchyimport/call.src/group.ts: removedconsolidateTeamHierarchyandconsolidateNode. KeptassignLevels/pruneEmptyChildren— still used bynestOverlappingLabels/groupByTeamHierarchy.src/output.ts/src/tui.ts: removedconsolidateTeamSectionsfromReplayOptions,buildReplayCommand,buildOutput, andrunInteractive.src/completions.ts: removed the completion entry.CHANGELOG.md: updated the pendingv2.0.0summary.Closes #196.
How did you verify your code works?
bun test(977 passing),bun run lint,bun run format:check,bun run knip,bun run build.tsall green.grep -ri consolidatacross the repo.