Add --pick-team-auto: auto-resolve combined sections by common prefix - #199
Draft
shouze wants to merge 1 commit into
Draft
Add --pick-team-auto: auto-resolve combined sections by common prefix#199shouze wants to merge 1 commit into
shouze wants to merge 1 commit into
Conversation
Auto-resolves a combined team section (e.g. "gamme-lead-client + gamme-lead-client-p1") to whichever team name is a literal prefix of every other team name in the combo, at any hierarchy depth. Combos with no common-prefix team are left combined/unresolved, and an explicit --pick-team for the same section always wins (auto-pick runs after explicit assignments). Closes #197
|
Coverage after merging feat/team-hierarchy-pick-team-auto into feat/team-hierarchy-remove-consolidate will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
🔦 Lighthouse Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
--pick-team-auto: automatically resolves combined team sections whose team names share a common prefix, at any hierarchy depth, without requiring an explicit--pick-team."a + b"), if exactly one team name is a literal string-prefix of every other team name in the combo (e.g.gamme-lead-clientfor"gamme-lead-client + gamme-lead-client-p1"), auto-resolve to that team."squad-frontend + squad-mobile") are left combined and unresolved — same as today,--pick-teamstill works for these.--pick-teamassignments, so an explicit pick for the same section always wins.src/group.ts: newautoPickTeamsByCommonPrefix(+ privatefindCommonPrefixTeamhelper).github-code-search.ts: new CLI flag, wired before the "unresolved combined sections" stderr note (now also triggered by--pick-team-auto).src/output.ts/src/tui.ts: threadedpickTeamAutothroughReplayOptions/buildReplayCommand/runInteractiveso a session using the flag replays identically.src/completions.ts: new completion entry.Closes #197. Depends on #198 (branch is stacked on top of it).
How did you verify your code works?
src/group.test.tscovering: single common-prefix winner, no common prefix (left combined), 3+-way combos (shortest-prefix wins), nested (non-top-level) sections, explicit-pick-wins-over-auto, purity, and no-op when nothing is combined.src/output.test.ts/src/completions.test.tsfor replay-command emission and completion scripts.bun test(990 passing),bun run lint,bun run format:check,bun run knip,bun run build.tsall green.