Register start-bb signal handlers before spawning - #2055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
runBuildProcess spawned its build process before registering SIGINT and SIGTERM handlers. A fast child could become externally observable during that window, allowing another process to send SIGTERM while Node still had its default signal behavior. The parent then exited with signal=SIGTERM instead of cleaning up the build leader and grandchild, which caused the flaky packages job on PR #2050.
What changed
Register the build signal handlers before spawning the child. Keep spawn inside the existing try/finally lifecycle so synchronous startup failures also remove both handlers. There are no wire, daemon protocol, CLI, persistence, or documentation contract changes.
How you verified
Follow-up to #2050.