Skip to content

Register start-bb signal handlers before spawning #2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ymichael merged 1 commit into from
Aug 20, 2026
Merged

Register start-bb signal handlers before spawning #2055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions scripts/start-bb.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,7 @@ function waitForProcess(child) {
}

export async function runBuildProcess(request) {
const child = spawn(request.command, request.args, {
cwd: request.cwd,
detached: supportsProcessGroups(),
env: request.env,
stdio: "inherit",
});
let child;
let stopPromise;
const stopChild = () => {
stopPromise ??= stopProcessGroupLeaderFirst({
Expand All @@ -42,10 +37,18 @@ export async function runBuildProcess(request) {
};
const handleSigint = () => stopChild();
const handleSigterm = () => stopChild();
// Register before spawn so a child that becomes ready immediately cannot
// prompt another process to signal us before the handlers exist.
process.on("SIGINT", handleSigint);
process.on("SIGTERM", handleSigterm);

try {
child = spawn(request.command, request.args, {
cwd: request.cwd,
detached: supportsProcessGroups(),
env: request.env,
stdio: "inherit",
});
const result = await waitForProcess(child);
await stopPromise;
return result;
Expand Down
Loading