ref(conversations): use publishExternally for external replies - #1238
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Persist reply delivery separately from Location so dashboard turns can stay in the conversation. Keep paused-turn delivery across resume and lease-expiry recovery so workers do not fall back to destination delivery. Refs #1200 Co-Authored-By: David Cramer <david@sentry.io>
sentry-junior
Bot
force-pushed
the
codex/conversation-reply-destination
branch
from
August 8, 2026 02:31
9a37df6 to
2de7e51
Compare
dcramer
added a commit
that referenced
this pull request
Aug 9, 2026
Move user-authored configuration off expiring Redis scratch into durable SQL, scoped to a provider Location. **Ownership** - `junior_location_configurations.location_id` references the canonical Location row in `junior_destinations` - Each `(location_id, key)` has one row with a text value - Runtime routing supplies a Destination only to resolve the associated Location; Destination remains reply-delivery data - API and entry scope use `Location` / `location` **Cutover** - Existing live Redis channel-state entries copy into Location configuration on the first Slack read - New writes go only to SQL - Concurrent SQL writes win over stale Redis entries - The Redis fallback has an explicit `#1267` / `v0.147.0` removal marker **Checks** - Typecheck and lint pass - Focused tests: 16/16 This follows the Source / Location / Destination split in #1200 and does not overlap the reply-delivery changes in #1238. Refs #1267 --------- Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: David Cramer <david@sentry.io>
Co-Authored-By: David Cramer <david@sentry.io>
Co-Authored-By: David Cramer <david@sentry.io>
Co-Authored-By: David Cramer <david@sentry.io>
sentry-junior
Bot
changed the title
dcramer
marked this pull request as ready for review
August 10, 2026 02:43
Replace the destination/conversation enum with one boolean side-effect flag. The conversation log always stores the turn; publishExternally only decides whether assistant output also goes to the conversation location. Keep the flag on mailbox work and the turn checkpoint. Refs #1200 Co-Authored-By: David Cramer <david@sentry.io>
sentry-junior
Bot
changed the title
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 202553b. Configure here.
Accidental TurnDelivery→boolean replace mangled the delivery-accepted hook. Co-Authored-By: David Cramer <david@sentry.io>
Require explicit true to publish externally. Resume reads the checkpoint flag, dispatch passes true, and destination presence no longer invents publish. Drop the one-line schema module and document the rule. Co-Authored-By: David Cramer <david@sentry.io>
Slack ingress and resume publish unless the flag is explicitly false. Non-Slack and destinationless work still stay conversation-only when unset. Restores auth-pause notices and failure fallbacks on Slack paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the
turnDeliveryenum with one boolean side effect on turn work.The conversation log always stores the turn.
publishExternallyonly decides whether assistant output also goes to the conversation destination. Slack and plugin dispatch set it true. Dashboard and destinationless child work set it false.Mailbox work and the turn checkpoint keep the flag through pause, resume, lease recovery, and retry. Slack ingress and resume publish unless the flag is explicitly false. Non-Slack work stays conversation-only when unset. Destination presence must not invent publish. The worker keeps different publish choices in separate turns.
Refs #1200
Checks
pnpm --filter @sentry/junior exec tsc -p tsconfig.json --noEmit