Skip to content

chore(tasks) Use a shared taskbroker container#609

Open
markstory wants to merge 1 commit intomainfrom
chore-taskbroker-shared
Open

chore(tasks) Use a shared taskbroker container#609
markstory wants to merge 1 commit intomainfrom
chore-taskbroker-shared

Conversation

@markstory
Copy link
Copy Markdown
Member

Align with sentry + seer usage of taskbroker as a shared local development service. I tested this locally with

devservices up taskbroker
make worker

The worker was able to connect to the taskbroker that was running.

Refs STREAM-874

Align with sentry + seer usage of taskbroker as a shared local
development service.

Refs STREAM-874
@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 4, 2026

Comment thread devservices/config.yml
Comment on lines +10 to 17
remote:
repo_name: taskbroker
branch: main
repo_link: https://github.com/getsentry/taskbroker.git
mode: containerized
modes:
default: []
containerized: [launchpad]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The mode: containerized setting in devservices/config.yml is incorrectly nested under the remote: block and should be a sibling attribute.
Severity: HIGH

Suggested Fix

In devservices/config.yml, move the mode: containerized line out from under the remote: block. Adjust its indentation to be at the same level as the remote: key, making them sibling attributes. This will ensure devservices correctly interprets the intended startup mode.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: devservices/config.yml#L10-L17

Potential issue: In `devservices/config.yml`, the `mode: containerized` attribute is
incorrectly placed inside the `remote:` block. The `mode` attribute should be a sibling
to the `remote:` block, not a child. This incorrect nesting will likely cause
`devservices` to ignore the `mode` setting because it is not a valid field within the
`remote:` configuration schema. As a result, the dependency will start in its default
mode instead of the intended containerized mode, leading to incorrect behavior in the
development or CI environment.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you wrong, all the other usage of mode: containerized are also nested under remote in sentry + seer.

@markstory markstory requested a review from a team May 5, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant