chore(tasks) Use a shared taskbroker container#609
Open
Conversation
Align with sentry + seer usage of taskbroker as a shared local development service. Refs STREAM-874
Comment on lines
+10
to
17
| remote: | ||
| repo_name: taskbroker | ||
| branch: main | ||
| repo_link: https://github.com/getsentry/taskbroker.git | ||
| mode: containerized | ||
| modes: | ||
| default: [] | ||
| containerized: [launchpad] |
Contributor
There was a problem hiding this comment.
Bug: The mode: containerized setting in devservices/config.yml is incorrectly nested under the remote: block and should be a sibling attribute.
Severity: HIGH
Suggested Fix
In devservices/config.yml, move the mode: containerized line out from under the remote: block. Adjust its indentation to be at the same level as the remote: key, making them sibling attributes. This will ensure devservices correctly interprets the intended startup mode.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: devservices/config.yml#L10-L17
Potential issue: In `devservices/config.yml`, the `mode: containerized` attribute is
incorrectly placed inside the `remote:` block. The `mode` attribute should be a sibling
to the `remote:` block, not a child. This incorrect nesting will likely cause
`devservices` to ignore the `mode` setting because it is not a valid field within the
`remote:` configuration schema. As a result, the dependency will start in its default
mode instead of the intended containerized mode, leading to incorrect behavior in the
development or CI environment.
Did we get this right? 👍 / 👎 to inform future reviews.
Member
Author
There was a problem hiding this comment.
you wrong, all the other usage of mode: containerized are also nested under remote in sentry + seer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align with sentry + seer usage of taskbroker as a shared local development service. I tested this locally with
The worker was able to connect to the taskbroker that was running.
Refs STREAM-874