Skip to content

chore(tasks) Use a shared taskbroker container #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
markstory wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(tasks) Use a shared taskbroker container #609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions devservices/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ x-sentry-service-config:
dependencies:
launchpad:
description: Service that powers preprod artifact analysis
taskbroker:
description: Taskbroker gRPC server
remote:
repo_name: taskbroker
branch: main
repo_link: https://github.com/getsentry/taskbroker.git
mode: containerized
modes:
default: []
containerized: [launchpad]
Comment on lines +10 to 17
Copy link
Copy Markdown
Contributor

@sentry sentry Bot May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The mode: containerized setting in devservices/config.yml is incorrectly nested under the remote: block and should be a sibling attribute.
Severity: HIGH

Suggested Fix

In devservices/config.yml, move the mode: containerized line out from under the remote: block. Adjust its indentation to be at the same level as the remote: key, making them sibling attributes. This will ensure devservices correctly interprets the intended startup mode.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: devservices/config.yml#L10-L17

Potential issue: In `devservices/config.yml`, the `mode: containerized` attribute is
incorrectly placed inside the `remote:` block. The `mode` attribute should be a sibling
to the `remote:` block, not a child. This incorrect nesting will likely cause
`devservices` to ignore the `mode` setting because it is not a valid field within the
`remote:` configuration schema. As a result, the dependency will start in its default
mode instead of the intended containerized mode, leading to incorrect behavior in the
development or CI environment.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Copy Markdown
Member Author

@markstory markstory May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you wrong, all the other usage of mode: containerized are also nested under remote in sentry + seer.

Expand Down
Loading