Skip to content

chore(deps): bump seaweedfs to 4.29 and migrate into weed mini#4345

Open
aldy505 wants to merge 4 commits into
masterfrom
aldy505/feat/bump-seaweedfs-425
Open

chore(deps): bump seaweedfs to 4.29 and migrate into weed mini#4345
aldy505 wants to merge 4 commits into
masterfrom
aldy505/feat/bump-seaweedfs-425

Conversation

@aldy505
Copy link
Copy Markdown
Collaborator

@aldy505 aldy505 commented May 22, 2026

Should help with executing lifecycle commands here: #4263

Should help with executing lifecycle commands here: #4263
@aminvakil
Copy link
Copy Markdown
Collaborator

Should help with executing lifecycle commands here: #4263

Can you please mention what feature from 4.17 to 4.25 helps here?

https://github.com/seaweedfs/seaweedfs/releases/tag/4.25

@aldy505
Copy link
Copy Markdown
Collaborator Author

aldy505 commented May 22, 2026

@aminvakil this: seaweedfs/seaweedfs#9346

Copy link
Copy Markdown
Collaborator

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Comment thread docker-compose.yml
Comment thread docker-compose.yml
-volume.port=8080
-volume.port.grpc=18080
-ip.bind=0.0.0.0
-webdav=false
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The seaweedfs health check uses port 9340, but the service command doesn't configure this port. The service may not be listening on 9340, causing the health check to fail.
Severity: HIGH

Suggested Fix

Verify the correct health check port for the SeaweedFS 4.29 weed mini volume server. If 9340 is incorrect, update the health check URL to use the correct port, such as the previously used 8080 or another documented default. If 9340 is correct, add an explicit port mapping and/or command-line flag to the seaweedfs service definition to ensure it listens on that port.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: docker-compose.yml#L282

Potential issue: The health check for the `seaweedfs` service is configured to make a
request to `http://seaweedfs:9340/healthz`. However, the `weed mini` command for the
service does not include any flags to expose or bind to port `9340`. The previous
configuration explicitly used port `8080`. While some external documentation hints that
the Volume Server might use port `9340`, the official SeaweedFS documentation for `weed
mini` does not list it as a default port. This mismatch will likely cause the health
check to fail, marking the container as unhealthy and potentially causing dependent
services to fail to start.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 15595c7. Configure here.

Comment thread docker-compose.yml
-filer.defaultReplicaPlacement=000
-master=true
-master.port=9333
-master.port.grpc=19333
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed -volume.max=0 may limit volume count

Medium Severity

The old configuration explicitly set -volume.max=0 which auto-configures volume count based on available disk space. This flag was removed in the switch to mini mode. In the server command, the default for volume.max is 8 (not unlimited). If the mini command inherits this same default, the system will be limited to 8 volumes, after which new writes will fail — potentially causing data loss for nodestore and profiles storage.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 15595c7. Configure here.

@aldy505
Copy link
Copy Markdown
Collaborator Author

aldy505 commented May 28, 2026

Okay that works?

@aldy505 aldy505 changed the title chore(deps): bump seaweedfs to 4.25 chore(deps): bump seaweedfs to 4.29 May 28, 2026
Copy link
Copy Markdown
Collaborator

@aminvakil aminvakil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this, but maybe we should change PR's name that is not just about bumping version, but weed server is getting changed to weed mini.

@aldy505 aldy505 changed the title chore(deps): bump seaweedfs to 4.29 chore(deps): bump seaweedfs to 4.29 and migrate into weed mini May 29, 2026
@aldy505 aldy505 linked an issue May 30, 2026 that may be closed by this pull request
1 task
@aldy505 aldy505 linked an issue May 30, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Seaweedfs cleanup doesnot work because of Ttl:3M Upgrade to 26.4.2 hanging on Retrying failed request: /?lifecycle

2 participants