Skip to content

chore(deps): bump seaweedfs to 4.29 and migrate into weed mini #4345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aldy505 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore(deps): bump seaweedfs to 4.29 and migrate into weed mini #4345

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7da4406
chore(deps): bump seaweedfs to 4.25
aldy505 May 22, 2026
deb4b04
chore(deps): bump seaweedfs to 4.29
aldy505 May 28, 2026
6a655ec
Merge branch 'master' into aldy505/feat/bump-seaweedfs-425
aldy505 May 28, 2026
15595c7
feat!: move to weed mini and remove other seaweedfs container
aldy505 May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 3 additions & 42 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,30 +254,17 @@ services:
retries: 30
seaweedfs:
<<: *restart_policy
image: "chrislusf/seaweedfs:4.17_large_disk"
image: "chrislusf/seaweedfs:4.29_large_disk@sha256:e5ca7cc6b61cf5d89a5f85821e0cf115a9765e2d1f27223cbb7722c7837c024e"
Comment thread
aldy505 marked this conversation as resolved.
entrypoint: "weed"
command: >-
server
mini
-dir=/data
-filer=true
-filer.port=8888
-filer.port.grpc=18888
-filer.defaultReplicaPlacement=000
-master=true
-master.port=9333
-master.port.grpc=19333
Copy link
Copy Markdown

@cursor cursor Bot May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed -volume.max=0 may limit volume count

Medium Severity

The old configuration explicitly set -volume.max=0 which auto-configures volume count based on available disk space. This flag was removed in the switch to mini mode. In the server command, the default for volume.max is 8 (not unlimited). If the mini command inherits this same default, the system will be limited to 8 volumes, after which new writes will fail — potentially causing data loss for nodestore and profiles storage.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 15595c7. Configure here.

-metricsPort=9091
-s3=true
-s3.port=8333
-s3.port.grpc=18333
-volume=true
-volume.dir.idx=/data/idx
-volume.index=leveldbLarge
-volume.max=0
-volume.preStopSeconds=8
-volume.readMode=redirect
-volume.port=8080
-volume.port.grpc=18080
-ip.bind=0.0.0.0
-webdav=false
Copy link
Copy Markdown

@sentry sentry Bot May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The seaweedfs health check uses port 9340, but the service command doesn't configure this port. The service may not be listening on 9340, causing the health check to fail.
Severity: HIGH

Suggested Fix

Verify the correct health check port for the SeaweedFS 4.29 weed mini volume server. If 9340 is incorrect, update the health check URL to use the correct port, such as the previously used 8080 or another documented default. If 9340 is correct, add an explicit port mapping and/or command-line flag to the seaweedfs service definition to ensure it listens on that port.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: docker-compose.yml#L282

Potential issue: The health check for the `seaweedfs` service is configured to make a
request to `http://seaweedfs:9340/healthz`. However, the `weed mini` command for the
service does not include any flags to expose or bind to port `9340`. The previous
configuration explicitly used port `8080`. While some external documentation hints that
the Volume Server might use port `9340`, the official SeaweedFS documentation for `weed
mini` does not list it as a default port. This mismatch will likely cause the health
check to fail, marking the container as unhealthy and potentially causing dependent
services to fail to start.

environment:
Expand All @@ -292,38 +279,12 @@ services:
# Manually override any http_proxy envvar that might be set, because
# this wget does not support no_proxy. See:
# https://github.com/getsentry/self-hosted/issues/1537
"http_proxy='' wget -q -O- http://seaweedfs:8080/healthz http://seaweedfs:9333/cluster/healthz http://seaweedfs:8333/healthz || exit 1",
"http_proxy='' wget -q -O- http://seaweedfs:9340/healthz http://seaweedfs:9333/cluster/healthz http://seaweedfs:8333/healthz || exit 1",
]
interval: 30s
timeout: 20s
retries: 5
start_period: 60s
seaweedfs-admin:
<<: *restart_policy
image: "chrislusf/seaweedfs:4.17_large_disk"
entrypoint: "weed"
command: >-
admin
-port=23646
-master=seaweedfs:9333
environment:
<<: *force_no_proxy
depends_on:
seaweedfs:
<<: *depends_on-healthy
seaweedfs-worker:
<<: *restart_policy
image: "chrislusf/seaweedfs:4.17_large_disk"
entrypoint: "weed"
command: >-
worker
-admin=seaweedfs-admin:23646
-jobType=all
environment:
<<: *force_no_proxy
depends_on:
seaweedfs-admin:
<<: *depends_on-default
snuba-api:
<<: *snuba_defaults
healthcheck:
Expand Down
Loading