fix(test): Fix flaky MetricsTabContent sidebar toggle test#111847
Closed
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Closed
fix(test): Fix flaky MetricsTabContent sidebar toggle test#111847JoshuaKGoldberg wants to merge 1 commit intomasterfrom
JoshuaKGoldberg wants to merge 1 commit intomasterfrom
Conversation
Wait for the SearchQueryBuilderCombobox inside the re-expanded sidebar to finish initialising. Without this, its async state updates fire after the test ends and trigger an act() warning that jest-fail-on-console catches, causing flaky failures (4 occurrences in the last 30 days). Co-Authored-By: Claude Sonnet 4 <noreply@example.com> Made-with: Cursor
github-actions
bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wait for the SearchQueryBuilderCombobox inside the re-expanded sidebar to finish initialising. Without this, its async state updates fire after the test ends and trigger an act() warning that jest-fail-on-console catches, causing flaky failures.
The test
toggles the query builder sidebar with the expand controlcollapses and re-expands the sidebar, but only waited for the toolbartestIdto reappear. TheSearchQueryBuilderComboboxinside the toolbar was still running async initialisation, so its state updates leaked past the test boundary. Adding awaitForon the combobox role inside the toolbar ensures all updates have settled before the test completes.This test failed 4 times on master in the last 30 days.
Made with Cursor