Skip to content

fix(test): Fix flaky MetricsTabContent sidebar toggle test #111847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshuaKGoldberg wants to merge 1 commit into from
Closed

fix(test): Fix flaky MetricsTabContent sidebar toggle test #111847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions static/app/views/explore/metrics/metricsTab.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,5 +731,14 @@ describe('MetricsTabContent (tracemetrics-ui-refresh)', () => {
await waitFor(() => {
expect(screen.getAllByTestId('metric-toolbar')).toHaveLength(1);
});

// Wait for the SearchQueryBuilderCombobox inside the re-expanded sidebar to
// finish initialising, otherwise its async state updates fire after the test
// ends and trigger an act() warning that jest-fail-on-console catches.
await waitFor(() => {
expect(
within(screen.getAllByTestId('metric-toolbar')[0]!).getByRole('combobox')
).toBeInTheDocument();
});
});
});
Loading