test(java): re-enable ModeHandlers exit_plan_mode E2E assertions#2032
Open
arimu1 wants to merge 1 commit into
Open
test(java): re-enable ModeHandlers exit_plan_mode E2E assertions#2032arimu1 wants to merge 1 commit into
arimu1 wants to merge 1 commit into
Conversation
Remove the CLI 1.0.57 @disabled workaround and assert the canonical action order (autopilot, interactive, exit_only) plus recommendedAction, matching the other language SDKs after snapshot updates. Fixes github#1547 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-enables
ModeHandlersTest.shouldInvokeExitPlanModeHandlerWhenModelUsesTool, which was@Disabledin #1548 after the CLI 1.0.57 upgrade.Shared snapshot work landed in #1639 and the other language SDKs were updated for the canonical action order in #2023; Java was still skipped because this test remained disabled.
This PR:
@Disabledworkaround["autopilot", "interactive", "exit_only"]andrecommendedAction == "interactive"Fixes #1547
Test plan
cd test/harness && npm cicd java && mvn verify(local Copilot/GitHub auth as needed for E2E snapshots)ModeHandlersTestis greenMade with Cursor