Skip to content

test(java): re-enable ModeHandlers exit_plan_mode E2E assertions #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arimu1 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

test(java): re-enable ModeHandlers exit_plan_mode E2E assertions #2032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions java/src/test/java/com/github/copilot/ModeHandlersTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@
import static org.junit.jupiter.api.Assertions.*;

import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.TimeUnit;

import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import com.github.copilot.generated.ExitPlanModeAction;
Expand Down Expand Up @@ -68,7 +68,6 @@ private void configureAuthenticatedUser(String testName) throws Exception {
}

@Test
@Disabled("Snapshot needs re-recording for CLI 1.0.57: https://github.com/github/copilot-sdk/issues/1547")
void shouldInvokeExitPlanModeHandlerWhenModelUsesTool() throws Exception {
final String summary = "Greeting file implementation plan";
configureAuthenticatedUser("should_invoke_exit_plan_mode_handler_when_model_uses_tool");
Expand Down Expand Up @@ -103,16 +102,19 @@ void shouldInvokeExitPlanModeHandlerWhenModelUsesTool() throws Exception {

var request = handlerCalled.get(10, TimeUnit.SECONDS);
assertEquals(summary, request.getSummary());
assertNotNull(request.getActions());
assertTrue(request.getActions().contains("interactive"));
// Canonical action order after CLI 1.0.57+ (aligned with #2023 / other SDKs).
assertEquals(List.of("autopilot", "interactive", "exit_only"), request.getActions());
assertEquals("interactive", request.getRecommendedAction());
assertNotNull(request.getPlanContent());

var reqEvent = requestedEvent.get(10, TimeUnit.SECONDS);
assertEquals(request.getSummary(), reqEvent.getData().summary());
assertEquals(ExitPlanModeAction.INTERACTIVE, reqEvent.getData().recommendedAction());

var compEvent = completedEvent.get(10, TimeUnit.SECONDS);
assertTrue(compEvent.getData().approved());
assertEquals(ExitPlanModeAction.INTERACTIVE, compEvent.getData().selectedAction());
assertEquals("Approved by the Java E2E test", compEvent.getData().feedback());

assertNotNull(response);

Expand Down