Skip to content

fix(sonar): run container smoke test as non-root user (docker:S6471) - #22

Merged
setchy merged 1 commit into
mainfrom
fix/sonar-docker-S6471
Oct 8, 2026
Merged

setchy merged 1 commit into
mainfrom
fix/sonar-docker-S6471

Conversation

@setchy

@setchy setchy commented Oct 4, 2026 •

Copy link
Copy Markdown
Member

SonarCloud

Resolves the open docker:S6471 issue for tests/shell/Dockerfile.

Changes

  • tests/shell/Dockerfile: run the smoke-test container as a non-privileged gitify system user instead of root — create a dedicated gitify group and system user, pre-create /run/dbus and chown it to gitify so the system message bus can still start, add USER gitify, and drop the now-redundant mkdir from the CMD (docker:S6471).

The base image keeps Renovate's tag@digest form so Renovate can keep updating it. Per the Renovate Docker docs: "When pinning a digest, Renovate retains the Docker tag in the FROM line for readability." Sonar's docker:S8431 no longer flags tag@digest references in projects that contain a Renovate configuration file.

Validation

  • vp check — all files correctly formatted, no lint warnings
  • node --experimental-vm-modules --test tests/*.test.js — 8/8 pass
  • Based on latest main
  • CI: GNOME 50/51 Wayland smoke tests, Lint, actionlint, zizmor, Bundle, and SonarCloud all pass

@setchy
setchy force-pushed the fix/sonar-docker-S6471 branch from 3948969 to d0d37e1 Compare October 4, 2026 12:06
@setchy
setchy marked this pull request as ready for review October 4, 2026 12:13
@setchy
setchy requested a review from afonsojramos as a code owner October 4, 2026 12:13
@setchy
setchy force-pushed the fix/sonar-docker-S6471 branch from d0d37e1 to ded6603 Compare October 7, 2026 16:01
@setchy
setchy marked this pull request as draft October 7, 2026 16:52
@setchy
setchy force-pushed the fix/sonar-docker-S6471 branch 2 times, most recently from c6fd18c to 8ff9b3c Compare October 8, 2026 13:41
@setchy
setchy force-pushed the fix/sonar-docker-S6471 branch from 8ff9b3c to 9538315 Compare October 8, 2026 13:45
@sonarqubecloud

sonarqubecloud Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gitify-app gitify-app deleted a comment from Copilot AI Oct 8, 2026
@gitify-app gitify-app deleted a comment from Copilot AI Oct 8, 2026
@setchy
setchy marked this pull request as ready for review October 8, 2026 14:02
@setchy
setchy merged commit 7735b37 into main Oct 8, 2026
8 checks passed
@setchy
setchy deleted the fix/sonar-docker-S6471 branch October 8, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant