Skip to content

fix(sonar): run container smoke test as non-root user (docker:S6471) #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
setchy merged 1 commit into from
Oct 8, 2026
Merged

fix(sonar): run container smoke test as non-root user (docker:S6471) #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions tests/shell/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,21 @@
ARG GNOME_TEST_IMAGE=ubuntu:26.04@sha256:cd21a4f68a617580279d4b091cb18e3af9fa8a87500665f0ae5f7f757d17d367
FROM ${GNOME_TEST_IMAGE}

Check warning on line 2 in tests/shell/Dockerfile

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Use either the version tag or the digest for the image instead of both. 


See more on https://sonarcloud.io/project/issues?id=gitify-app_gnome&issues=AaEbwB2x3l_nKXA3F1Vo&open=AaEbwB2x3l_nKXA3F1Vo&pullRequest=22

RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \
dbus-x11 gir1.2-gdkpixbuf-2.0 gir1.2-gtk-4.0 gnome-shell gnome-shell-extension-appindicator python3-gi \
&& rm -rf /var/lib/apt/lists/* \
&& rmdir /run/systemd/seats
&& rmdir /run/systemd/seats \
&& groupadd --system gitify \
&& useradd --create-home --system --gid gitify gitify \
&& mkdir -p /run/dbus \
&& chown gitify:gitify /run/dbus

WORKDIR /work
COPY LICENSE LICENSE
COPY gitify@gitify.io gitify@gitify.io
COPY tests/shell tests/shell
COPY scripts/test-shell.sh scripts/test-shell.sh

CMD ["bash", "-c", "mkdir -p /run/dbus && dbus-daemon --system --fork && exec bash scripts/test-shell.sh"]
USER gitify

CMD ["bash", "-c", "dbus-daemon --system --fork && exec bash scripts/test-shell.sh"]
Loading