Pass release version to shell via env, not interpolation (SEC-11868) - #178
Open
leonard-tesnov wants to merge 1 commit into
Open
leonard-tesnov wants to merge 1 commit into
leonard-tesnov wants to merge 1 commit into
Conversation
The publish job interpolated ${{ steps.version_check.outputs.version }}
and ${{ steps.notes.outputs.notes }} directly into `run:` bodies.
Actions substitutes those textually before the shell runs, so the values
are parsed as shell source rather than read as data. The version comes
from lib/gocardless_pro/version.rb and the notes from CHANGELOG.md.
Bind both through step-level `env:` so the shell reads them as data, and
reject a version that is not plain semver at the point it is read.
Passing the notes via `env:` also preserves their line breaks, which the
previous inline assignment did not.
Ref: SEC-11868
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The publish job interpolated ${{ steps.version_check.outputs.version }} and ${{ steps.notes.outputs.notes }} directly into
run:bodies. Actions substitutes those textually before the shell runs, so the values are parsed as shell source rather than read as data. The version comes from lib/gocardless_pro/version.rb and the notes from CHANGELOG.md.Bind both through step-level
env:so the shell reads them as data, and reject a version that is not plain semver at the point it is read.Passing the notes via
env:also preserves their line breaks, which the previous inline assignment did not.Ref: SEC-11868