Skip to content

Pass release version to shell via env, not interpolation (SEC-11868) #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leonard-tesnov wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pass release version to shell via env, not interpolation (SEC-11868) #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ jobs:
GH_TOKEN: ${{ github.token }}
run: |
VERSION=$(ruby -r ./lib/gocardless_pro/version.rb -e 'puts GoCardlessPro::VERSION')
# Guard against a crafted version string reaching later shell commands.
if [[ ! "$VERSION" =~ ^[0-9]+\.[0-9]+\.[0-9]+([-+][0-9A-Za-z.-]+)?$ ]]; then
echo "Refusing to release: '$VERSION' is not a valid semantic version"
exit 1
fi
echo "version=$VERSION" >> $GITHUB_OUTPUT
if gh release view "v$VERSION" >/dev/null 2>&1; then
echo "already_published=true" >> $GITHUB_OUTPUT
Expand All @@ -80,8 +85,9 @@ jobs:
- name: Extract changelog notes for this version
id: notes
if: steps.version_check.outputs.already_published == 'false'
env:
VERSION: ${{ steps.version_check.outputs.version }}
run: |
VERSION="${{ steps.version_check.outputs.version }}"
NOTES=""
if [ -f CHANGELOG.md ]; then
NOTES=$(awk -v ver="$VERSION" '
Expand All @@ -100,9 +106,10 @@ jobs:
if: steps.version_check.outputs.already_published == 'false'
env:
GH_TOKEN: ${{ github.token }}
VERSION: ${{ steps.version_check.outputs.version }}
NOTES: ${{ steps.notes.outputs.notes }}
run: |
NOTES="${{ steps.notes.outputs.notes }}"
TAG="v${{ steps.version_check.outputs.version }}"
TAG="v${VERSION}"
if [ -n "$(echo "$NOTES" | tr -d '[:space:]')" ]; then
gh release create "$TAG" --title "$TAG" --notes "$NOTES"
else
Expand Down