fix: scope SQLite race contract deadlines - #23
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Scope the concurrent workflow store contract deadlines to each policy subtest. Keep the existing 10 second deadlock guard, while allowing each SQLite policy its own execution budget under the race detector.
Why
Queue PR #22 passed its exact-head checks, but the merge commit's root race job exposed shared deadline exhaustion in two sequential SQLite contract tests. The first policy consumed most of a parent context, so the second policy inherited an almost-expired deadline and failed with
context deadline exceeded. This is test-only timing isolation. It does not change the queue API, configuration, persisted data, minimum Go version, or runtime behavior.