Skip to content

fix: scope SQLite race contract deadlines #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmilesio merged 1 commit into from
Sep 7, 2026
+4 −4
Merged

fix: scope SQLite race contract deadlines #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions internal/workflow/store_contract_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1205,8 +1205,6 @@ func TestStoreContract_ConcurrentBatchJobOutcomeOwnership(t *testing.T) {
func TestStoreContract_ConcurrentTerminalBatchJobOutcomeOwnership(t *testing.T) {
for name, factory := range testStoreFactories(t) {
t.Run(name, func(t *testing.T) {
ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
defer cancel()
for _, policy := range []struct {
name string
allowFailures bool
Expand All @@ -1215,6 +1213,8 @@ func TestStoreContract_ConcurrentTerminalBatchJobOutcomeOwnership(t *testing.T)
{name: "fail_fast", allowFailures: false},
} {
t.Run(policy.name, func(t *testing.T) {
ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)
defer cancel()
for iteration := range 6 {
store := factory(t)
outcomes := requireOutcomeStore(t, store)
Expand Down Expand Up @@ -1338,8 +1338,6 @@ func TestStoreContract_ConcurrentDistinctBatchSettlement(t *testing.T) {
for name, factory := range testStoreFactories(t) {
t.Run(name, func(t *testing.T) {
s := factory(t)
ctx, cancel := context.WithTimeout(context.Background(), 7*time.Second)
defer cancel()
const jobCount = 32
jobs := make([]BatchJob, jobCount)
for i := range jobs {
Expand All @@ -1356,6 +1354,8 @@ func TestStoreContract_ConcurrentDistinctBatchSettlement(t *testing.T) {
{name: "fail_fast", allowFailures: false},
} {
t.Run(policy.name, func(t *testing.T) {
ctx, cancel := context.WithTimeout(context.Background(), 15*time.Second)
defer cancel()
batchID := "batch-concurrent-distinct-" + policy.name
if err := s.CreateBatch(ctx, BatchRecord{
BatchID: batchID,
Expand Down