fix: serialize SQLite workflow writes - #24
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Serialize transactional workflow writes within each SQLite-backed store. Apply the same lock to chain advancement, chain failure, batch creation, batch settlement, and pruning so every workflow transaction follows one SQLite write policy.
Why
The SQLite 1.58 migration passed PR CI, but two consecutive merge-commit runs exposed
SQLITE_BUSYduring 32-way terminal batch settlement under the race detector. SQLite permits one writer, and competing deferred transactions can still be rejected after the configured busy timeout. Per-store serialization reflects that database constraint and preserves successful concurrent queue behavior without changing public APIs, configuration, persisted data, the minimum Go version, or non-SQLite drivers.