Skip to content

fix: serialize SQLite workflow writes #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmilesio merged 1 commit into from
Sep 7, 2026
Merged

fix: serialize SQLite workflow writes #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions internal/workflow/store_sql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,11 +73,22 @@ type sqlStore struct {
driverName string
autoMigrate bool
mysqlKeyLimit mysqlWorkflowKeyLimits
sqliteWriteMu sync.Mutex

ensureMu sync.Mutex
schemaReady bool
}

// lockWriteTransaction serializes transactions within one SQLite store because
// SQLite permits only one writer and can reject competing deferred transactions.
func (s *sqlStore) lockWriteTransaction() func() {
if s.driverName != "sqlite" {
return func() {}
}
s.sqliteWriteMu.Lock()
return s.sqliteWriteMu.Unlock
}

// transitionReceiptQueryer lets receipt reads share one implementation across
// committed database state and an in-flight workflow transaction.
type transitionReceiptQueryer interface {
Expand Down Expand Up @@ -559,6 +570,7 @@ func (s *sqlStore) advanceChainOutcome(ctx context.Context, chainID string, comp
if state.DispatchID != "" && claim.dispatchID != "" && state.DispatchID != claim.dispatchID {
return chainAdvanceResult{}, fmt.Errorf("chain %q dispatch mismatch", chainID)
}
defer s.lockWriteTransaction()()
tx, err := s.db.BeginTx(ctx, nil)
if err != nil {
return chainAdvanceResult{}, err
Expand Down Expand Up @@ -694,6 +706,7 @@ func (s *sqlStore) failChainOutcome(ctx context.Context, chainID, nodeID string,
if cause != nil {
message = cause.Error()
}
defer s.lockWriteTransaction()()
tx, err := s.db.BeginTx(ctx, nil)
if err != nil {
return chainFailureResult{}, err
Expand Down Expand Up @@ -831,6 +844,7 @@ func (s *sqlStore) CreateBatch(ctx context.Context, rec BatchRecord) error {
return err
}
}
defer s.lockWriteTransaction()()
tx, err := s.db.BeginTx(ctx, nil)
if err != nil {
return err
Expand Down Expand Up @@ -1006,6 +1020,7 @@ func (s *sqlStore) Prune(ctx context.Context, before time.Time) error {
return err
}
cutoff := before.UnixMilli()
defer s.lockWriteTransaction()()
tx, err := s.db.BeginTx(ctx, nil)
if err != nil {
return err
Expand Down Expand Up @@ -1058,6 +1073,7 @@ func (s *sqlStore) markBatchTerminal(ctx context.Context, batchID, jobID string,
if err := s.ensureSchema(ctx); err != nil {
return BatchState{}, false, false, false, transitionReceipt{}, false, err
}
defer s.lockWriteTransaction()()
tx, err := s.db.BeginTx(ctx, nil)
if err != nil {
return BatchState{}, false, false, false, transitionReceipt{}, false, err
Expand Down